-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix errors due to "unused code" when features are disabled #368
Conversation
Review changes with SemanticDiff. Analyzed 2 of 2 files. Overall, the semantic diff is 10% smaller than the GitHub diff.
|
As I said, this isn’t about compiling but about clippy. Using latest stable (1.77.2) I get when running
|
Whatever, I’ve rearranged this code so that we don’t have any warnings here. The optimizer can figure it out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
Unfortunately, my previous changes caused some compile errors when compiling with
--no-default-features
. That’s mostly due to unused code, one error is because of a variable being unnecessarily mutable.Related Issue
#340, #342
How Has This Been Tested?
Tests pass.