VR: extend to verify some cstr benchmarks #66
Conversation
| @@ -0,0 +1,17959 @@ | |||
| /* | |||
| * Catch v2.13.7 | |||
| * Generated: 2021-07-28 20:29:27.753164 | |||
There was a problem hiding this comment.
This file is generated. Should it really be versioned in Git?
There was a problem hiding this comment.
I believe I wanted to add it properly as a dependency, but I think the problem was that the CMake version does not support FetchContent (and my knowledge of CMake is too limited to be able to do it otherwise), so I added the one necessary file manually. I believe it is done in the same way in tests for dg.
|
This are the commits from svcomp22 branch right? Don't know how much they are polished, but they have been quite well tested as they were used in SV-COMP 22. Also, I do not know how much @GiraffeReversed will react on any request for changes, so maybe they are good to be merged as they are? (maybe with some cosmetic changes). |
There was a problem hiding this comment.
I haven't went through the commits, but I have tested them repeatedly (and they ran in SV-COMP'22), so once all cosmetic issues are solved, I think they are good to be merged. Sorry that they are not in the svcomp22 branch, but apparently I haven't pushed the final state of the branch to github...
|
Hi :) I don't really know what the requested cosmetic changes are... (but hopefully I am able to perform them after the exam period). |
Tested on SV-COMP21_valid-memsafety category, changed no answers except for newly verified benchmarks.
Depends on VR: use fixed and refactored version #65.