BUG: Decode metadata to utf-8. Closes #1326. #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think it closes 1326 yet. There is at least additionally the double decoding when reading from cache. |
|
Can you try it, since I can't reproduce? Can you point to the double decoding? I don't see what you mean. |
|
I'm running out the door to a snow festival, I can look into it tonight |
|
Sure. Sounds good. Have fun! |
|
@andreas-h Can you give this a whirl? (Or make the changes locally and see if it fixes your problem) |
|
Sounds like this is alright to merge. |
|
looks good for this part. only the first commit is necessary. |
jseabold
added a commit
that referenced
this pull request
Jan 26, 2014
BUG: Decode metadata to utf-8. Closes #1326.
PierreBdR
pushed a commit
to PierreBdR/statsmodels
that referenced
this pull request
Sep 2, 2014
BUG: Decode metadata to utf-8. Closes statsmodels#1326.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.