Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tmp corr tools #1567

Closed
wants to merge 25 commits into from
Closed

Tmp corr tools #1567

wants to merge 25 commits into from

Conversation

kshedden
Copy link
Contributor

@kshedden kshedden commented Apr 7, 2014

Here is a rebased version of the correlation tools PR. Hopefully it is OK to merge, but let me know if there are issues.

@jseabold
Copy link
Member

jseabold commented Apr 7, 2014

Hmm, it looks like maybe you are merging master into your branch? Have a look at the changeset for that last commit. It's got every change from master in it, which isn't right. If the commit before looks good I can rebase it for you and you can work off my branch if need be, or if you want to learn we can work through it. How exactly did you do the rebase?

@kshedden
Copy link
Contributor Author

kshedden commented Apr 7, 2014

Help is appreciated... I tried to do as suggested in your earlier email.

Something was messed up in my master when I started this branch, hence
there are some unwanted dotplot commits at the beginning. I eventually
removed those files, but the commit messages are still there in the
history. There should be only three files affected in this PR. I checked
and I think that the files are correct and up to date. It's just the
commit history that is messed up.

On Mon, Apr 7, 2014 at 9:46 AM, Skipper Seabold notifications@github.comwrote:

Hmm, it looks like maybe you are merging master into your branch? Have a
look at the changeset for that last commit. It's got every change from
master in it, which isn't right. If the commit before looks good I can
rebase it for you and you can work off my branch if need be, or if you want
to learn we can work through it. How exactly did you do the rebase?

Reply to this email directly or view it on GitHubhttps://github.com//pull/1567#issuecomment-39690277
.

@josef-pkt
Copy link
Member

Sorry, I had forgotten about the included dotplot commits.
This might be better done with an interactive rebase, maybe based on the original PR.

If there are no changes, git makes an "empty" commit, but I think usually the git messages still show up, unless the commit is identified as being the same as a previous commit IIRC.

The network graph shows this branch as a fork of the original and as a merge of master into it, not as a rebase.

I think we can wait for an easier rebase for Kerby to figure out some of the tricky git tricks.

I'lll look into the rebase and merge.

@josef-pkt josef-pkt added the PR label Apr 14, 2014
@kshedden kshedden deleted the tmp-corr-tools branch June 9, 2014 01:58
PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this pull request Sep 2, 2014
@bashtage bashtage added the rejected Used for PRs with changes that are not acceptable label Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rejected Used for PRs with changes that are not acceptable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants