-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG graphics influence plot, switched criterion #3158
BUG graphics influence plot, switched criterion #3158
Conversation
the test doesn't seem to work with any of the matplotlib used on travis, i.e. <1.5 possible problem with try...except catching is that the unit test might never run at all. |
maintenance, some test methods create several plots but don't close them https://travis-ci.org/statsmodels/statsmodels/jobs/152251848
I still get tkinter warnings in TestPlot.test_plot_oth unless I comment out the add_lowess loop. I still don't see where this comes from.
|
78fdab3
to
2f54d07
Compare
test_power is the last one, the entire test suite runs now for me also.
(second error is in an extra file, that was left over from a different branch) |
some cosmetic changes would be possible, but in it goes |
…_3103 BUG graphics influence plot, switched criterion
closes #3103
I added a unit test to compare the sizes used in the plot, but it uses a matplotlib figure private attribute
_sizes
. This is most likely not robust, and might need to betry except AttributeError
protectedI used matplotlib '1.5.1', and tests pass on my computer (only for the test method, I still get segfaults running the test class)
Detail (as explanation to test code): the plotted sizes are a affine transformation of the influence criterion, so I check that the residuals of the linear regression are close to zero.