-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Kernel density notebook update #4207
Conversation
1 similar comment
@tommyod Thanks for the improvement I only had time for a very quick skimming of it. the only comment directly to the content is that icdf doesn't fit in the plot with cdf and sf. |
Codecov Report
@@ Coverage Diff @@
## master #4207 +/- ##
=========================================
Coverage ? 79.55%
=========================================
Files ? 562
Lines ? 83816
Branches ? 9551
=========================================
Hits ? 66683
Misses ? 14947
Partials ? 2186 Continue to review full report at Codecov.
|
Changes Unknown when pulling d475bf4 on tommyod:kernel_density into ** on statsmodels:master**. |
Changes Unknown when pulling b357286 on tommyod:kernel_density into ** on statsmodels:master**. |
1 similar comment
Changes Unknown when pulling b357286 on tommyod:kernel_density into ** on statsmodels:master**. |
@josef-pkt Thanks for the review. I read through again and wrote a little bit more. I removed the output of the Jupyter Notebook, and addressed the comment about the domain of the inverse CDF as per your request :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think using alpha=0.5 for the histograms except the first would look better, better visibility of plot lines on top of histogram
"dist1_loc, dist1_scale, weight1 = -1 , .5, .25\n", | ||
"dist2_loc, dist2_scale, weight2 = 1 , .5, .75\n", | ||
"\n", | ||
"# Sample from a micture of distributions\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo mixture
A squashed and rebased version of this is now in #4551 |
First PR to statsmodels. The Jupyter Notebook on Kernel Density Estimation seemed very incomplete to me, so I updated it with the following:
bw
argument (the bandwidth of the kernel).I also fixed a minor typo.
Comments very welcome!