Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused resetlist #4468

Merged
merged 3 commits into from
May 2, 2019
Merged

Conversation

jbrockmendel
Copy link
Contributor

The "resettable" part of ResettableCache is never actually used. By removing it we make it easier to reason about the behavior of the code.

@josef-pkt
Copy link
Member

This pull request fixes 1 alert when merging 058a007 into 5188211 - view on lgtm.com

fixed alerts:

  • 1 for __eq__ not overridden when adding attributes

Comment posted by lgtm.com

@coveralls
Copy link

coveralls commented Apr 12, 2018

Coverage Status

Coverage decreased (-0.06%) to 84.473% when pulling 0fe5928 on jbrockmendel:resetlist into 1246e75 on statsmodels:master.

@codecov-io
Copy link

codecov-io commented Apr 12, 2018

Codecov Report

Merging #4468 into master will decrease coverage by 0.45%.
The diff coverage is 95.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4468      +/-   ##
==========================================
- Coverage   81.98%   81.52%   -0.46%     
==========================================
  Files         588      569      -19     
  Lines       93151    89570    -3581     
  Branches    10325    10024     -301     
==========================================
- Hits        76371    73026    -3345     
+ Misses      14406    14272     -134     
+ Partials     2374     2272     -102
Impacted Files Coverage Δ
statsmodels/tools/decorators.py 86.88% <100%> (-3.26%) ⬇️
statsmodels/stats/contingency_tables.py 86.98% <100%> (+0.31%) ⬆️
statsmodels/graphics/gofplots.py 82.35% <100%> (ø) ⬆️
statsmodels/tools/tests/test_decorators.py 90.9% <100%> (-5.1%) ⬇️
statsmodels/genmod/generalized_linear_model.py 90.7% <100%> (-0.4%) ⬇️
statsmodels/nonparametric/kde.py 85.81% <100%> (ø) ⬆️
statsmodels/base/model.py 85.86% <100%> (-1.45%) ⬇️
statsmodels/tsa/arima_model.py 86.44% <100%> (-0.43%) ⬇️
...smodels/genmod/generalized_estimating_equations.py 83.1% <100%> (+0.22%) ⬆️
statsmodels/tsa/statespace/mlemodel.py 85.96% <100%> (-0.23%) ⬇️
... and 202 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1246e75...0fe5928. Read the comment docs.

@jbrockmendel
Copy link
Contributor Author

@josef-pkt this is an area where I have strong comparative advantage: willingness to figure out what "plumbing" parts of code are actually needed.

@bashtage
Copy link
Member

bashtage commented May 2, 2019

Needs a rebase.

@bashtage bashtage merged commit 188d553 into statsmodels:master May 2, 2019
@jbrockmendel jbrockmendel deleted the resetlist branch May 2, 2019 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants