-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unused resetlist #4468
remove unused resetlist #4468
Conversation
This pull request fixes 1 alert when merging 058a007 into 5188211 - view on lgtm.com fixed alerts:
Comment posted by lgtm.com |
Codecov Report
@@ Coverage Diff @@
## master #4468 +/- ##
==========================================
- Coverage 81.98% 81.52% -0.46%
==========================================
Files 588 569 -19
Lines 93151 89570 -3581
Branches 10325 10024 -301
==========================================
- Hits 76371 73026 -3345
+ Misses 14406 14272 -134
+ Partials 2374 2272 -102
Continue to review full report at Codecov.
|
058a007
to
8a37ee4
Compare
9a52d8b
to
86fac69
Compare
@josef-pkt this is an area where I have strong comparative advantage: willingness to figure out what "plumbing" parts of code are actually needed. |
Needs a rebase. |
The "resettable" part of ResettableCache is never actually used. By removing it we make it easier to reason about the behavior of the code.