Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLN/TST] Follow instructions to remove function #4998

Merged
merged 2 commits into from
Aug 26, 2018

Conversation

jbrockmendel
Copy link
Contributor

Add a few files to the strict-linting list

@jbrockmendel
Copy link
Contributor Author

Whoops, evidently forgot to update the lint file. Will add these in the next pass.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 83.861% when pulling 7eab99f on jbrockmendel:main_tools5 into 8675b89 on statsmodels:master.

@codecov-io
Copy link

Codecov Report

Merging #4998 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4998      +/-   ##
==========================================
- Coverage   81.33%   81.32%   -0.01%     
==========================================
  Files         582      582              
  Lines       90026    90018       -8     
  Branches    10093    10091       -2     
==========================================
- Hits        73224    73211      -13     
+ Misses      14507    14506       -1     
- Partials     2295     2301       +6
Impacted Files Coverage Δ
statsmodels/tools/transform_model.py 78.57% <ø> (-0.74%) ⬇️
statsmodels/tools/grouputils.py 61.2% <ø> (+0.69%) ⬆️
statsmodels/stats/sandwich_covariance.py 75.27% <100%> (+0.54%) ⬆️
statsmodels/tools/tests/test_transform_model.py 100% <100%> (ø) ⬆️
statsmodels/regression/mixed_linear_model.py 88.97% <0%> (-0.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8675b89...7eab99f. Read the comment docs.

@jbrockmendel
Copy link
Contributor Author

Whoops, evidently forgot to update the lint file. Will add these in the next pass.

@josef-pkt if there are no objections, I'd rather add that to the lint file in a separate PR and avoid CI clog since this is green

@josef-pkt
Copy link
Member

looks fine to me, merging

@josef-pkt josef-pkt merged commit 195b723 into statsmodels:master Aug 26, 2018
@jbrockmendel jbrockmendel deleted the main_tools5 branch August 26, 2018 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants