Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: consolidate version checks, remove outdated #5157

Closed
wants to merge 7 commits into from
Closed

TST: consolidate version checks, remove outdated #5157

wants to merge 7 commits into from

Conversation

jbrockmendel
Copy link
Contributor

Closes #1063.

We recently removed some version checks for unsupported numpy/scipy/pandas versions, but missed a few. This gets most or all of the remaining ones.

Consolidates version checks in the compat files so that in the future they are all in one place when it comes time to update the minimum required versions.

jbrockmendel
jbrockmendel commented Sep 9, 2018
View reviewed changes
statsmodels/compat/pandas.py Outdated
@@ -7,6 +7,8 @@


version = LooseVersion(pandas.__version__)
pandas_lt_0_19_2 = version < '0.19.1'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches the existing code, but there is a 0.19.2 vs 0.19.1 mismatch. Please advise.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surely should be lte and <= '0.19.2'

@jbrockmendel
Copy link
Contributor Author

Related: #5036

@coveralls
Copy link

coveralls commented Sep 9, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 84.015% when pulling 27533b3 on jbrockmendel:pversion into e8615f5 on statsmodels:master.

@codecov
Copy link

codecov bot commented Sep 10, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@319ddc6). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5157   +/-   ##
=========================================
  Coverage          ?   81.55%           
=========================================
  Files             ?      569           
  Lines             ?    89610           
  Branches          ?    10027           
=========================================
  Hits              ?    73078           
  Misses            ?    14265           
  Partials          ?     2267
Impacted Files Coverage Δ
statsmodels/multivariate/tests/test_factor.py 90.62% <ø> (ø)
statsmodels/imputation/tests/test_ros.py 100% <ø> (ø)
statsmodels/graphics/tests/test_tsaplots.py 99.31% <100%> (ø)
statsmodels/graphics/tests/test_mosaicplot.py 99.62% <100%> (ø)
statsmodels/stats/tests/test_power.py 93.89% <100%> (ø)
statsmodels/stats/mediation.py 94.96% <100%> (ø)
statsmodels/tsa/vector_ar/tests/test_dynamic.py 29.54% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 319ddc6...7b54424. Read the comment docs.

@bashtage
Copy link
Member

LGTM

@jbrockmendel jbrockmendel mentioned this pull request Sep 10, 2018
Closed
32 tasks
@jbrockmendel
Copy link
Contributor Author

jbrockmendel commented Sep 11, 2018 •
edited
Loading

@josef-pkt defacto green, OKed by bashtage, and no merge conflict

@jbrockmendel
Copy link
Contributor Author

@josef-pkt merge conflicts are going to start piling up before too long...

@jbrockmendel jbrockmendel mentioned this pull request Sep 16, 2018
Closed
@jbrockmendel
Copy link
Contributor Author

@josef-pkt this consolidation should definitely happen before 0.10.0

@jbrockmendel jbrockmendel mentioned this pull request Sep 22, 2018
Merged
@jbrockmendel
Copy link
Contributor Author

@josef-pkt any thoughts here?

@jbrockmendel
Copy link
Contributor Author

@josef-pkt let's do version-checking right

@jbrockmendel jbrockmendel mentioned this pull request Dec 7, 2018
Merged
@jbrockmendel
Copy link
Contributor Author

@ChadFulton prevent future complications

@bashtage bashtage mentioned this pull request May 1, 2019
Merged
3 tasks
@jbrockmendel jbrockmendel deleted the pversion branch May 2, 2019 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashtage bashtage bashtage left review comments

Assignees
No one assigned
Labels
type-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove version compatibility code
3 participants
@jbrockmendel @coveralls @bashtage