MAINT: fix incorrect TypeError --> ValueError #5194
Conversation
|
Aside from needing to fix the test, these all look right to me. |
|
Test fixed, CI fail is false-positive from coveralls. |
|
@josef-pkt appveyor fail is in corrpsd, this is de facto green. |
|
@josef-pkt green, i think this is the last of these |
| @@ -653,7 +654,9 @@ def test_lagmat2ds_use_pandas(self): | |||
|
|
|||
| def test_3d_error(self): | |||
| data = np.array(2) | |||
| assert_raises(TypeError, sm.tsa.lagmat2ds, data, 5) | |||
| with pytest.raises(ValueError): | |||
| sm.tsa.lagmat2ds(data, 5) | |||
There was a problem hiding this comment.
why did you change this?
This looks completley unrelated to the rest of the PR and the description of the PR.
And in general I still prefer numpy testing to pytest
There was a problem hiding this comment.
The TypeError needed to be changed to ValueError. While I was at it I changed it to use the modern context syntax.
There was a problem hiding this comment.
ok, this is not my "usual" neighborhood anymore, so ok with me
|
Well done sir. I think #5192 is the last one in this genre at the moment |
No description provided.