-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set python3 as interpreter for doc tools #5348
Conversation
The scripts require python3 so the interpreter should use that. python does not point to python3 on most distributions.
@bashtage @thequackdaddy any comments? |
I would probably reject this since python3 isn't necessarily available on all platforms. Essentially these should be run in a vurtual env with python 3.6+ as the default interpreter, in which case python is fine. |
python3 should be available on all platforms where this execution method is available, see the recommendations of https://www.python.org/dev/peps/pep-0394/ By using python for python3 scripts you are breaking all unix like distributions except arch (where python3 also exists). virtualenv should also have python3 available if not that is a bug as it is violating the pep. |
related thread https://groups.google.com/forum/#!topic/comp.lang.python/YGwlPPxeVr8 |
to clarify the doc build requirements. Does the doc build now require python 3 or does it still work with python 2.7 also? If the former, then the change looks useful to force python 3. |
it does not work in python2, the files use python3 features, e.g. futures or the encoding argument of open |
The expectation of this file, and the doc generation in general, is that it is run in an environment where python 3 is the default python. |
That assumption does not fit with pythons own pep. I do not see why statsmodels is different from all other python software in this regard that it must assume this non-standard behaviour. |
merged, |
The scripts require python3 so the interpreter should use that.
python does not point to python3 on most distributions.