CLN: Fix F901 and E306 mixups #5352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ChadFulton raising NotImplemented is egregious enough that it should actually be fixed. |
|
Thanks @jbrockmendel |
| @@ -166,6 +166,7 @@ def get_lilliefors_table(dist='norm'): | |||
|
|
|||
|
|
|||
| # also build a table for larger sample sizes | |||
|
|
|||
There was a problem hiding this comment.
@jbrockmendel I think we actually should've removed lines here. flake8 can be confusing/finicky
There was a problem hiding this comment.
I made a quick fix is #5335 ... let's see if I know what I'm doing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #5325