Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.10.2 cherry #6269

Merged
merged 17 commits into from Nov 23, 2019
Merged

0.10.2 cherry #6269

merged 17 commits into from Nov 23, 2019

Conversation

bashtage
Copy link
Member

  • closes #xxxx
  • tests added / passed.
  • code/documentation is well formatted.
  • properly formatted commit message. See
    NumPy's guide.

Notes:

  • It is essential that you add a test when making code changes. Tests are not
    needed for doc changes.
  • When adding a new function, test values should usually be verified in another package (e.g., R/SAS/Stata).
  • When fixing a bug, you must add a test that would produce the bug in master and
    then show that it is fixed with the new code.
  • New code additions must be well formatted. Changes should pass flake8. If on Linux or OSX, you can
    verify you changes are well formatted by running
    git diff upstream/master -u -- "*.py" | flake8 --diff --isolated
    
    assuming flake8 is installed. This command is also available on Windows
    using the Windows System for Linux once flake8 is installed in the
    local Linux environment. While passing this test is not required, it is good practice and it help
    improve code quality in statsmodels.
  • Docstring additions must render correctly, including escapes and LaTeX.

bashtage and others added 15 commits November 22, 2019 22:49
BUG: Fix mosaic plot with missing category
Turn relative import into an absolute import
DOC: Fix notebook due to pandas index change
MAINT/SEC: Remove unnecessary pickle use
BUG: Remove extra LICENSE.txt and setup.cfg
BUG: MLEModel now passes nobs to Representation
@coveralls
Copy link

coveralls commented Nov 22, 2019

Coverage Status

Coverage decreased (-0.1%) to 84.946% when pulling 878d975 on bashtage:0.10.2-cherry into 3889c8d on statsmodels:maintenance/0.10.x.

@codecov
Copy link

codecov bot commented Nov 22, 2019

Codecov Report

Merging #6269 into maintenance/0.10.x will decrease coverage by 0.16%.
The diff coverage is 19.03%.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           maintenance/0.10.x    #6269      +/-   ##
======================================================
- Coverage               82.55%   82.38%   -0.17%     
======================================================
  Files                     598      599       +1     
  Lines                   94488    94992     +504     
  Branches                10424    10529     +105     
======================================================
+ Hits                    78005    78261     +256     
- Misses                  14060    14303     +243     
- Partials                 2423     2428       +5
Impacted Files Coverage Δ
statsmodels/sandbox/stats/multicomp.py 40.6% <ø> (ø) ⬆️
statsmodels/iolib/smpickle.py 100% <ø> (ø) ⬆️
statsmodels/datasets/tests/test_utils.py 88.46% <ø> (ø) ⬆️
statsmodels/tools/docstring.py 0% <0%> (ø)
...models/tsa/statespace/tests/test_representation.py 99.37% <100%> (+0.04%) ⬆️
statsmodels/tsa/stattools.py 88.05% <100%> (+0.02%) ⬆️
statsmodels/tsa/statespace/mlemodel.py 86.23% <100%> (ø) ⬆️
statsmodels/tsa/tests/test_stattools.py 98.93% <100%> (ø) ⬆️
statsmodels/tsa/statespace/tests/test_mlemodel.py 100% <100%> (ø) ⬆️
statsmodels/stats/correlation_tools.py 90.59% <100%> (ø) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3889c8d...0d48f24. Read the comment docs.

Enforce flake8
@lgtm-com
Copy link

lgtm-com bot commented Nov 23, 2019

This pull request introduces 3 alerts when merging 878d975 into 3889c8d - view on LGTM.com

new alerts:

  • 3 for Variable defined multiple times

Add whats new for 0.10.2
Pin parts fo travis needed to build
@bashtage bashtage merged commit 988699f into statsmodels:maintenance/0.10.x Nov 23, 2019
@bashtage bashtage deleted the 0.10.2-cherry branch November 23, 2019 08:19
@lgtm-com
Copy link

lgtm-com bot commented Nov 23, 2019

This pull request introduces 3 alerts when merging 0d48f24 into 3889c8d - view on LGTM.com

new alerts:

  • 3 for Variable defined multiple times

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants