Added SVAR option to plot_cum_effects in irf #9107
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plot_cum_effects function lacked SVAR check: when it was called for SVAR, it returned VAR cumulative IRFs despide them being calculated for SVAR internally. Thus one elif case has beed added to resolve this issue.
Example:
Current behavior: returns VAR cumulative IR's (self.cum_effects).
Expected behavior: returns SVAR cumulative IR's (self.svar_cum_effects)