update emojihash and identicon ring specs #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cammellos
reviewed
May 6, 2022
| @@ -91,15 +91,16 @@ Prerequisites: User is in onboarding process or has already set up a profile and | |||
| - Users MUST be able to set a profile photo for their profile | |||
| - Profile photos MUST be visible to all users | |||
|
|
|||
| - A identicon ring MUST be composed of 10 color segments | |||
| - Unless a profile has a registered ENS username, it MUST show the identicon ring around the profile avatar | |||
There was a problem hiding this comment.
The ring should be shown even if the user has a ENS profile, ENS usernames are not immutable, for example:
- ENS name blah.eth is registered with PK1
- PK1 contacts user A, no ring is shown because
blah.ethis registered to PK1, PK1 uses profile picture X - ENS name blah.eth is then registered to a different public key, PK2
- PK2 contacts user A, using profile picture X
At this point you can't tell PK1 & PK2 apart, so they can be impersonated.
The ring should always be shown in my opinion, the only exception could possibly be verified contacts (not mutual), but in my opinion is not worth it, better to always be consistent so the user understands the purpose of it, but that's just my 2p, though for ENS we should def show the ring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.