Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new group chat spec #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: new group chat spec #75

wants to merge 1 commit into from

Conversation

osmaczko
Copy link

closes: #71

- New group member MUST be Admin's mutual contact

## Members removal
- Only Admin CAN remove User

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens to group chat when a user is removed? Should it become a read-only one and inactive but keep the chat in the user's chat list or will the chat be deleted automatically? If kept, should it be marked differently in the chat list view (ie read-only mode mark)?

content/raw/chat/group_chat.md Outdated Show resolved Hide resolved
- Only Admin CAN change the name of the group
- Only Admin CAN change the image of the group
- Only Admin CAN change the color of the group
- Unless explicitly changed, group name MUST follow given pattern:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a technical comment here: I think it should be implemented in status-go. Whenever the members change, the chat name is automatically changed (unless it was manually changed) to add / remove members from the chat name and follow the described syntax.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, agreed 👍 (Just to keep in mind, it will need mobile adaptation as well)

- Group chat CAN have more than one Admin
- Only Admin CAN promote User to the Admin role

## Members addition

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a question related specifically to the view / design @John-44 :
Which should be the workflow to close the "tag selector panel" once it has been open to add / remove members and there are no changes in members or admin simply wants to go back and do no modifications?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a question related specifically to the view / design @John-44 : Which should be the workflow to close the "tag selector panel" once it has been open to add / remove members and there are no changes in members or admin simply wants to go back and do no modifications?

Confirmed with @John-44, by using Confirm button or by clicking outside the component will Cancel the action and close the panel.

content/raw/chat/group_chat.md Outdated Show resolved Hide resolved
content/raw/chat/group_chat.md Outdated Show resolved Hide resolved
@osmaczko osmaczko force-pushed the feat/group-chat-spec branch 2 times, most recently from 0132564 to 79e9e0e Compare May 23, 2022 08:34
@osmaczko osmaczko marked this pull request as draft June 3, 2022 13:03
@osmaczko osmaczko marked this pull request as ready for review June 9, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

write feature spec for groups functionality
3 participants