-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new group chat spec #75
base: master
Are you sure you want to change the base?
Conversation
content/raw/chat/group_chat.md
Outdated
- New group member MUST be Admin's mutual contact | ||
|
||
## Members removal | ||
- Only Admin CAN remove User |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens to group chat when a user is removed? Should it become a read-only one and inactive but keep the chat in the user's chat list or will the chat be deleted automatically? If kept, should it be marked differently in the chat list view (ie read-only mode mark)?
content/raw/chat/group_chat.md
Outdated
- Only Admin CAN change the name of the group | ||
- Only Admin CAN change the image of the group | ||
- Only Admin CAN change the color of the group | ||
- Unless explicitly changed, group name MUST follow given pattern: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a technical comment here: I think it should be implemented in status-go
. Whenever the members change, the chat name is automatically changed (unless it was manually changed) to add / remove members from the chat name and follow the described syntax.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, agreed 👍 (Just to keep in mind, it will need mobile adaptation as well)
content/raw/chat/group_chat.md
Outdated
- Group chat CAN have more than one Admin | ||
- Only Admin CAN promote User to the Admin role | ||
|
||
## Members addition |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a question related specifically to the view / design @John-44 :
Which should be the workflow to close the "tag selector panel" once it has been open to add / remove members and there are no changes in members or admin simply wants to go back and do no modifications?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a question related specifically to the view / design @John-44 : Which should be the workflow to close the "tag selector panel" once it has been open to add / remove members and there are no changes in members or admin simply wants to go back and do no modifications?
Confirmed with @John-44, by using Confirm
button or by clicking outside the component will Cancel
the action and close the panel.
0132564
to
79e9e0e
Compare
79e9e0e
to
3bcd490
Compare
closes: #71
3bcd490
to
d66c586
Compare
closes: #71