Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FutureVar test #245

Closed
wants to merge 1 commit into from
Closed

Add FutureVar test #245

wants to merge 1 commit into from

Conversation

Menduist
Copy link
Contributor

Copied the FutureVar test from asyncdispatch, fixed some basic stuff, but the test doesn't pass yet. WIP

@Menduist Menduist changed the title Add future var test and some fixes Add FutureVar test Nov 29, 2021
@Menduist Menduist mentioned this pull request Nov 29, 2021
Merged
@cheatfate
Copy link
Collaborator

@Menduist there is no reason to keep this FutureVar in our codebase, we are not going to use this broken functionality anytime soon. (cc @arnetheduck).

@Menduist Menduist mentioned this pull request Dec 1, 2021
Merged
@Menduist
Copy link
Contributor Author

Menduist commented Dec 8, 2021

Closed in favor of #247

@Menduist Menduist closed this Dec 8, 2021
@arnetheduck arnetheduck deleted the fixfuturevar branch June 8, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Menduist @cheatfate