Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hash_tree_root vs hash_tree_root_final #174

Closed
arnetheduck opened this issue Mar 13, 2019 · 1 comment · Fixed by #202
Closed

hash_tree_root vs hash_tree_root_final #174

arnetheduck opened this issue Mar 13, 2019 · 1 comment · Fixed by #202

Comments

@arnetheduck
Copy link
Member

our code confuses the naming here vs spec with regards to zero padding - needs updating (hash_tree_root is the padded version in spec)
arnetheduck added a commit that referenced this issue Mar 24, 2019
@arnetheduck
ssz: update to 0.5.1:ish
ac8d17c 
* slightly fewer seq allocations
* still a lot of potential for optimization
* fixes #174
@arnetheduck arnetheduck mentioned this issue Mar 24, 2019
Merged
@mratsim
Copy link
Contributor

mratsim commented Mar 25, 2019

I think the spec evolved to finally produce digests from the hash_tree_root function but we kept the old name for the old meaning in eb369ce

arnetheduck added a commit that referenced this issue Mar 25, 2019
@arnetheduck
ssz: update to 0.5.1:ish (#202)
1b0e67c 
* ssz: update to 0.5.1:ish
* slightly fewer seq allocations
* still a lot of potential for optimization
* fixes #174
* ssz: avoid reallocating leaves (logN merkle impl)
etan-status pushed a commit that referenced this issue May 12, 2022
@arnetheduck
add explicit gcsafe annotations (fixes #174) (#175)
895fc53 
Seems like a variation of nim-lang/Nim#17369
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ssz: update to 0.5.1:ish status-im/nimbus-eth2
2 participants
@arnetheduck @mratsim