Beacon cleanup #116
Merged
Beacon cleanup #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnetheduck
force-pushed
the
beacon-cleanup
branch
2 times, most recently
from
47b04c4
to
6d48c8c
Compare
|
Seems to have some, but not all of, #115 ? |
mratsim
approved these changes
Feb 15, 2019
| @@ -37,13 +37,13 @@ if [[ -z "$SKIP_BUILDS" ]]; then | |||
| fi | |||
|
|
|||
| if [ ! -f $STARTUP_FILE ]; then | |||
| $VALIDATOR_KEYGEN_BIN --validators=$NUMBER_OF_VALIDATORS --outputDir="$SIMULATION_DIR" # --startupDelay=2 | |||
| $VALIDATOR_KEYGEN_BIN --validators=$NUMBER_OF_VALIDATORS --outputDir="$SIMULATION_DIR" | |||
There was a problem hiding this comment.
I think it's good to keep it so that we don't need to track it down again. (Or it can be another env variable)
There was a problem hiding this comment.
it moved below and is called genesisoffset (because I did the code change first and didn't see this one)..
arnetheduck
force-pushed
the
beacon-cleanup
branch
from
6d48c8c
to
f12d6fe
Compare
|
oops, missed #115 when pushing this,rebased |
* remove previous randao scheme code * fix some epoch logging * move genesis time selection to state generation
arnetheduck
force-pushed
the
beacon-cleanup
branch
from
f12d6fe
to
e206882
Compare
This was referenced Feb 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.