Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix state cache loading #2631

Merged
merged 1 commit into from
Jun 3, 2021
Merged

fix state cache loading #2631

merged 1 commit into from
Jun 3, 2021

Conversation

arnetheduck
Copy link
Member

  • load the cache of the current state epoch instead of the target state
    epoch, when applying states and slots
  • load state cache for each slot/block (for longer slot jumps)
  • load state cache after full updateStateData
  • look up two state cache epochs, instead of the same epoch twice :)

* load the cache of the current state epoch instead of the target state
epoch, when applying states and slots
* load state cache for each slot/block (for longer slot jumps)
* load state cache after full updateStateData
* look up two state cache epochs, instead of the same epoch twice :)
@arnetheduck
Copy link
Member Author

This fixes the root cause for what's going on in #2614

Syncing performance profile, pre:

Screenshot from 2021-05-19 12-23-34

Post:

Screenshot from 2021-06-03 14-41-44

@tersec
Copy link
Contributor

tersec commented Jun 3, 2021

What's the validator count for those profiles?

@arnetheduck
Copy link
Member Author

arnetheduck commented Jun 3, 2021

mainnet, syncing around block 1231891, so about 150k vals, give or take (the post numbers - the pre numbers, I don't remember tbh).

@github-actions
Copy link

github-actions bot commented Jun 3, 2021

Unit Test Results

     28 files  ±0     328 suites  ±0   13m 1s ⏱️ ±0s
   625 tests ±0     607 ✔️ ±0    18 💤 ±0  0 ❌ ±0 
3 428 runs  ±0  3 324 ✔️ ±0  104 💤 ±0  0 ❌ ±0 

Results for commit b11da2c. ± Comparison against base commit b11da2c.

♻️ This comment has been updated with latest results.

@zah zah merged commit b11da2c into unstable Jun 3, 2021
@zah zah deleted the state-cache-fixes branch June 3, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants