Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up process_crosslinks(...) and get_crosslink_deltas(...) by 10x - 15x in state_sim #314

Merged
merged 5 commits into from Jul 8, 2019
Merged

Speed up process_crosslinks(...) and get_crosslink_deltas(...) by 10x - 15x in state_sim #314

merged 5 commits into from Jul 8, 2019

Commits on Jul 8, 2019

  1. remove some low-hanging perf silliness from get_winning_crosslink_and… 

    …_attesting_indices(...) and switch inner/outer loop nesting order to get 10-15x function speedup for 128 and 512 validator cases by avoiding accidentally quadratic behavior, while keeping function signature unchanged and allowing easy ongoing verification of correctness of optimization
    @tersec
    tersec committed Jul 8, 2019
    Copy the full SHA
    d8f63d2 View commit details
    Browse the repository at this point in the history

  2. avoid memory allocation with an openarray rather than seq

    @tersec
    tersec committed Jul 8, 2019
    Copy the full SHA
    61f388f View commit details
    Browse the repository at this point in the history

  3. update get_crosslink_deltas(...) to 0.8.0

    @tersec
    tersec committed Jul 8, 2019
    Copy the full SHA
    776833e View commit details
    Browse the repository at this point in the history

  4. move non-spec ValidatorSetDeltaFlags from datatypes.nim to sync_proto… 

    …col; fix mainnet MIN_ATTESTATION_INCLUSION_DELAY preset; update get_attestation_deltas(...) to 0.8.0; for 512 validators, get 90x speedup for get_attestation_deltas(...) from 179s to 2s
    @tersec
    tersec committed Jul 8, 2019
    Copy the full SHA
    4590b69 View commit details
    Browse the repository at this point in the history

  5. explain purpose of when false portions, so they can be removed once a… 

    …ccomplished
    @tersec
    tersec committed Jul 8, 2019
    Copy the full SHA
    b8618f1 View commit details
    Browse the repository at this point in the history