Add support for TOML config files (--config-file) #3442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnetheduck
reviewed
Feb 28, 2022
arnetheduck
reviewed
Feb 28, 2022
| @@ -14,7 +14,7 @@ import | |||
| std/[os, tables, strutils, terminal, typetraits], | |||
|
|
|||
| # Nimble packages | |||
| chronos, confutils, | |||
| chronos, confutils, toml_serialization, | |||
There was a problem hiding this comment.
why is toml_serialization here? shouldn't it be in conf.nim?
There was a problem hiding this comment.
It's used here as well. We refer to the Toml format type when we decide which config path to load. I guess I could have re-exported it from conf.nim, but conf.nim is a popular file, so it would have resulted in more pollution.
There was a problem hiding this comment.
I find it's better to reexport regardless - we've had enough trouble with imports, the reexport makes for shorter import lists overall which helps find circular imports - it also makes for fewer compiler errors and weird import-order problems which lead to formatting issues in log files etc
arnetheduck
approved these changes
Mar 4, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.