update presets / configs / REST config for v1.1.10 #3614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated outdated presets / configs / REST config to v1.1.10 specs. - `TERMINAL_BLOCK_HASH_ACTIVATION_EPOCH` and `PROPOSER_SCORE_BOOST` are not yet used in `eth2-networks`, added configurability as TODOs. - `MIN_ANCHOR_POW_BLOCK_DIFFICULTY` is no longer needed, put on ignore list as some Altair devnets still reference it.
tersec
approved these changes
May 5, 2022
tersec
reviewed
May 5, 2022
| @@ -148,6 +147,7 @@ const | |||
| "DOMAIN_CONTRIBUTION_AND_PROOF", | |||
|
|
|||
| "TRANSITION_TOTAL_DIFFICULTY", # Name that appears in some altair alphas, obsolete, remove when no more testnets | |||
| "MIN_ANCHOR_POW_BLOCK_DIFFICULTY", # Name that appears in some altair alphas, obsolete, remove when no more testnets | |||
There was a problem hiding this comment.
It's marked here so it can be found and removed if desired, but in general, I don't know how relevant it is to support such Altair devnets. There's not much cost this way, so seems reasonable to include it for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated outdated presets / configs / REST config to v1.1.10 specs.
TERMINAL_BLOCK_HASH_ACTIVATION_EPOCHandPROPOSER_SCORE_BOOSTarenot yet used in
eth2-networks, added configurability as TODOs.MIN_ANCHOR_POW_BLOCK_DIFFICULTYis no longer needed, put on ignorelist as some Altair devnets still reference it.