don't convert URL to lower ascii, fixes #3756 #3757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnetheduck
reviewed
Jun 15, 2022
beacon_chain/eth1/eth1_monitor.nim
Outdated
| @@ -262,7 +262,7 @@ template finalizedDepositsMerkleizer(m: Eth1Monitor): auto = | |||
| m.depositsChain.finalizedDepositsMerkleizer | |||
|
|
|||
| proc fixupWeb3Urls*(web3Url: var string) = | |||
| var normalizedUrl = toLowerAscii(web3Url) | |||
| var normalizedUrl = web3Url | |||
There was a problem hiding this comment.
the startsWith comparisons below need to be case-insentive
There was a problem hiding this comment.
Ok, I've done it differently in the following commit.
arnetheduck
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.