REST: fix timing check for bellatrix epoch. #3807
Conversation
| @@ -253,7 +267,15 @@ proc initFullNode( | |||
| finalizedEpochRef.eth1_data, | |||
| finalizedEpochRef.eth1_deposit_index) | |||
| node.updateLightClientFromDag() | |||
| eventBus.finalQueue.emit(data) | |||
| # TODO (cheatfate): Proper implementation required | |||
There was a problem hiding this comment.
With this PR, would this not have been accomplished? Of course, maybe what will be viewed as a proper implementation will change, but I'm not sure what this is standing in for (likewise the other TODO (cheatfate): Proper implementation required comments in similar place).
There was a problem hiding this comment.
Well, it always is either none or some(false) -- is it never intended to be some(true)?
What is fixed here is that the optimistic field is included as soon as wall clock passes past bellatrix, instead of this depending on the locally synced DAG head slot.
There was a problem hiding this comment.
For the moment, yes, it's never intended to be some(true). #3793 might change this, but Nimbus unstable is never an optimistic node, nor does it have optimistically imported blocks.
No description provided.