Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Interop] Fix genesis blockheader zero signature #395

Closed
wants to merge 6 commits into from
Closed

[Interop] Fix genesis blockheader zero signature #395

wants to merge 6 commits into from

Conversation

mratsim
Copy link
Contributor

@mratsim mratsim commented Sep 7, 2019

Another workaround needed due to #374

@mratsim mratsim changed the title Fix genesis blockheader zero signature [Interop] Fix genesis blockheader zero signature Sep 7, 2019
@mratsim
Copy link
Contributor Author

mratsim commented Sep 7, 2019 •
edited
Loading

It breaks "sanity check genesis roundtrip" in BeaconchainDB and also blockpool:

    /home/travis/gopath/src/github.com/status-im/nim-beacon-chain/tests/test_block_pool.nim(47, 18): Check failed: b1Ref.isSome()

    Unhandled exception: Can't obtain a value from a `none` [UnpackError:ObjectType]

  [FAILED] Simple block add&get [Preset: minimal]

    /home/travis/gopath/src/github.com/status-im/nim-beacon-chain/tests/test_block_pool.nim(71, 43): Check failed: hash_tree_root(state.data.data) == state.data.root

    hash_tree_root(state.data.data) was F2DC287FCB532F5291E5A3CE0475CB1FEA9739CBDCF48D2B14C883BEBA97E5CE

    state.data.root was 8E19702C61491AC8DC9E2449A2C7C37E16CC40AEF0F7C465D58FF8BEE3E77033

    /home/travis/gopath/src/github.com/status-im/nim-beacon-chain/tests/test_block_pool.nim(78, 16): Check failed: b1r.isSome()

    /home/travis/gopath/src/github.com/status-im/nim-beacon-chain/tests/test_block_pool.nim(79, 16): Check failed: b2r.isSome()

    Unhandled exception: Can't obtain a value from a `none` [UnpackError:ObjectType]

  [FAILED] Reverse order block add & get [Preset: minimal]

@mratsim mratsim mentioned this pull request Sep 7, 2019
Closed
mratsim added a commit that referenced this pull request Sep 7, 2019
@mratsim
Fix genesis blockheader zero signature (supercedes #395)
ae7df83
@mratsim mratsim mentioned this pull request Sep 7, 2019
Closed
@zah zah closed this Sep 7, 2019
mratsim added a commit that referenced this pull request Sep 8, 2019
@mratsim
Fix genesis blockheader zero signature (supercedes #395)
450f62a
mratsim added a commit that referenced this pull request Sep 8, 2019
@mratsim
Fix genesis blockheader zero signature (supercedes #395) (#400)
82b9e00
mratsim added a commit that referenced this pull request Sep 8, 2019
@mratsim
[interop] deactivate old beaconstate and state_transition test - work…
d74cd9d 
…ing interop scenario. Helps also for #403, #399, #395
mratsim added a commit that referenced this pull request Sep 8, 2019
@mratsim
[interop] deactivate old beaconstate and state_transition test - work…
dc768fa 
…ing interop scenario. Helps also for #403, #399, #395
arnetheduck pushed a commit that referenced this pull request Sep 9, 2019
@mratsim @arnetheduck
[interop] deactivate old beaconstate and state_transition test - work…
d1ece7f 
…ing interop scenario. Helps also for #403, #399, #395
arnetheduck pushed a commit that referenced this pull request Sep 10, 2019
@mratsim @arnetheduck
[interop] deactivate old beaconstate and state_transition test - work…
54251bb 
…ing interop scenario. Helps also for #403, #399, #395
@zah zah deleted the fix-genesis-zero-sig branch September 10, 2019 17:32
arnetheduck pushed a commit that referenced this pull request Sep 12, 2019
@mratsim @arnetheduck
[interop] deactivate old beaconstate and state_transition test - work…
dfd0a75 
…ing interop scenario. Helps also for #403, #399, #395
arnetheduck pushed a commit that referenced this pull request Sep 12, 2019
@mratsim @arnetheduck
[interop] deactivate old beaconstate and state_transition test - work…
fa15a77 
…ing interop scenario. Helps also for #403, #399, #395
arnetheduck pushed a commit that referenced this pull request Sep 27, 2019
@mratsim @arnetheduck
[interop] deactivate old beaconstate and state_transition test - work…
d03f69f 
…ing interop scenario. Helps also for #403, #399, #395
arnetheduck pushed a commit that referenced this pull request Sep 28, 2019
@mratsim @arnetheduck
[interop] deactivate old beaconstate and state_transition test - work…
7527882 
…ing interop scenario. Helps also for #403, #399, #395
arnetheduck pushed a commit that referenced this pull request Sep 28, 2019
@mratsim @arnetheduck
[interop] deactivate old beaconstate and state_transition test - work…
b217135 
…ing interop scenario. Helps also for #403, #399, #395
arnetheduck pushed a commit that referenced this pull request Sep 28, 2019
@mratsim @arnetheduck
[interop] deactivate old beaconstate and state_transition test - work…
bfd0fd0 
…ing interop scenario. Helps also for #403, #399, #395
arnetheduck pushed a commit that referenced this pull request Oct 1, 2019
@mratsim @arnetheduck
[interop] deactivate old beaconstate and state_transition test - work…
a319993 
…ing interop scenario. Helps also for #403, #399, #395
arnetheduck pushed a commit that referenced this pull request Oct 2, 2019
@mratsim @arnetheduck
[interop] deactivate old beaconstate and state_transition test - work…
4f39c5b 
…ing interop scenario. Helps also for #403, #399, #395
arnetheduck pushed a commit that referenced this pull request Oct 6, 2019
@mratsim @arnetheduck
[interop] deactivate old beaconstate and state_transition test - work…
4bfbcdf 
…ing interop scenario. Helps also for #403, #399, #395
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mratsim @zah