packaging updates #3974
Merged
packaging updates #3974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zah
reviewed
Aug 16, 2022
scripts/package_src/nimbus_beacon_node/image/lib/systemd/system/nimbus_beacon_node.service
Show resolved
Hide resolved
zah
reviewed
Aug 16, 2022
scripts/package_src/nimbus_beacon_node/image/lib/systemd/system/nimbus_beacon_node.service
Outdated
Show resolved
Hide resolved
|
|
||
| set -e | ||
|
|
||
| # TODO We purge the nimbus user / group / folder from the beacon node uninstall |
There was a problem hiding this comment.
Right, this looks like an open question.
There was a problem hiding this comment.
actually, turns out it it isn't - most guides recommend not to remove created users
...package_src/nimbus_validator_client/image/lib/systemd/system/nimbus_validator_client.service
Show resolved
Hide resolved
zah
reviewed
Aug 16, 2022
* one package per binary (nimbus_beacon_node, nimbus_validator_client) * use `-` in package name (`_` is separating the version) * don't include (un)installation scripts in package * default metrics port 8108 for vc * fix several upgrade/install errors in scripts * add JWT option to service files * don't attempt to remove user on purge
zah
reviewed
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-in package name (_is separating the version)