distinguish between optimistic and non-optimistic sync progress #3987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnetheduck
reviewed
Aug 18, 2022
| elif node.backfiller.inProgress: | ||
| "backfill: " & node.backfiller.syncStatus | ||
| elif node.dag.is_optimistic(node.dag.head.root): | ||
| elif optimistic_head: |
There was a problem hiding this comment.
I think it makes sense to keep the same formatting for both syncing and synced (so one can quickly grep for : opt for example
There was a problem hiding this comment.
maybe /opt instead which allows grepping without "" :)
arnetheduck
approved these changes
Aug 18, 2022
| elif node.backfiller.inProgress: | ||
| "backfill: " & node.backfiller.syncStatus | ||
| elif node.dag.is_optimistic(node.dag.head.root): | ||
| elif optimistic_head: |
There was a problem hiding this comment.
maybe /opt instead which allows grepping without "" :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3963
I'm not certain this is the best formatting, but it's arguably better to put the
optafter rather than before the time stamp, since there's a race-condition like setup where exactly when the execution client verifies a payload can vary, and this makes the churn more readable in that case.There's a case for doing this for "opt synced" too, but there, at least, there isn't any additional changing information to read (the estimated time).