Harden block proposal against expired slashings/exits #4013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a message is signed in a phase0 domain, it can no longer be validated under bellatrix due to the correct fork no longer being available in the `BeaconState`. To ensure that all slashing/exits are still valid, in this PR we re-run the checks in the state that we're proposing for, thus hardening against both signatures and other changes in the state that might have invalidated the message.
in case of attestation slashing of multiple validators in one go
arnetheduck
force-pushed
the
harden-exits
branch
from
9ce6d86
to
14f97d8
Compare
|
Hats off to @paulhauner for this one! |
|
Will there be a spec change for this? |
this has been in the spec since phase0 but it only becomes an issue now with a third fork (the beaconstate holds two forks, current and previous) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a message is signed in a phase0 domain, it can no longer be
validated under bellatrix due to the correct fork no longer being
available in the
BeaconState.To ensure that all slashing/exits are still valid, in this PR we re-run
the checks in the state that we're proposing for, thus hardening against
both signatures and other changes in the state that might have
invalidated the message.