bump news to fix concurrency bug with >1MB frames
#4028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling `newPayload` on a >1MB payload (can happen post-merge), `news` splits up that payload into 1MB chunks. The chunks are each sent individually, though, with `await` in-between. This means that when we send concurrent `forkChoiceUpdated` calls, that those may end up getting in-between the `newPayload` chunks, leading to invalid data being sent. The EL then returns an error message with a `null` `id` entry (as it could not read the request `id` due to the mangling) and disconnects. A PR has been submitted to fix this in `news`, and merged into `status` branch early as this fix is critical for reliable post-merge operation: Tormund/news#22
|
We've mostly kept the Status news repo used aligned with upstream, but this is an important enough fix that if we need to, it's okay to push it regardless. The other possibility is trying to resurrect |
|
the workaround being to use http instead, I guess? |
arnetheduck
approved these changes
Aug 25, 2022
|
I guess, HTTP has a different set of issues. WebSocket based setups should work, though. They are not documented to be broken, and expecting node operators to update their configurations yet another time is not feasible. But yes, experience with HTTP may vary in case of trouble. |
|
Manually tested by doing a full Sepolia sync on empty Geth / Nimbus DB with websocket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
newPayloadon a >1MB payload (can happen post-merge),newssplits up that payload into 1MB chunks. The chunks are each sentindividually, though, with
awaitin-between. This means that when wesend concurrent
forkChoiceUpdatedcalls, that those may end up gettingin-between the
newPayloadchunks, leading to invalid data being sent.The EL then returns an error message with a
nullidentry (as itcould not read the request
iddue to the mangling) and disconnects.A PR has been submitted to fix this in
news, and merged intostatusbranch early as this fix is critical for reliable post-merge operation:
Tormund/news#22