Fix messageId generation for forks following Altair #4076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Menduist
changed the title
etan-status
approved these changes
Sep 6, 2022
There was a problem hiding this comment.
Validated that topic.startsWith(altairPrefix) or topic.startsWith(bellatrixPrefix) at the everything >= altair. Probably fine without an assert, because if there is a new prefix scheme introduced in the future this portion is probably re-visited as part of potential work for that.
|
Actually, are messageId only put to GossipSub, or also to req/resp? If also applicable to req/rsp, maybe it looks like it is only applied to GossipSub, so assuming it's fine. |
|
Only to GossipSub topics AFAIK, req/resp use regular semver instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.