Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle INVALIDATED forkchoiceUpdated better #4081

Merged
merged 1 commit into from
Sep 7, 2022
Merged

handle INVALIDATED forkchoiceUpdated better #4081

merged 1 commit into from
Sep 7, 2022

Conversation

tersec
Copy link
Contributor

@tersec tersec commented Sep 6, 2022 •
edited

@tersec tersec mentioned this pull request Sep 6, 2022
Closed
etan-status
etan-status approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@etan-status etan-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

  • fcu invalid result is propagated to fork choice
  • fork choice is run again when current head becomes invalid.

Open question regarding treatment of INVALID in newPayload. Rest of functionality looks correct to me.

beacon_chain/consensus_object_pools/consensus_manager.nim Outdated Show resolved Hide resolved
beacon_chain/consensus_object_pools/consensus_manager.nim Outdated Show resolved Hide resolved
beacon_chain/consensus_object_pools/consensus_manager.nim Outdated Show resolved Hide resolved
beacon_chain/consensus_object_pools/consensus_manager.nim Outdated Show resolved Hide resolved
@arnetheduck arnetheduck merged commit cd46af1 into unstable Sep 7, 2022
@arnetheduck arnetheduck deleted the wPM branch September 7, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etan-status etan-status etan-status approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tersec @etan-status @arnetheduck