Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chunk large validator registrations #4364

Merged
merged 1 commit into from
Nov 26, 2022
Merged

chunk large validator registrations #4364

merged 1 commit into from
Nov 26, 2022

Conversation

tersec
Copy link
Contributor

@tersec tersec commented Nov 26, 2022

Otherwise large nodes might see, e.g.,:

{"lvl":"DBG","ts":"2022-11-26 19:26:36.267+00:00","msg":"REST request body has been sent","remote":"builder-relay-goerli.flashbots.net:443","request":"/eth/v1/builder/validators","size":3467933,"http_method":"POST","connection":"5"}
{"lvl":"DBG","ts":"2022-11-26 19:26:36.749+00:00","msg":"Got REST response headers from remote server","status":413,"http_method":"POST","remote":"builder-relay-goerli.flashbots.net:443","request":"/eth/v1/builder/validators","connection":"5"}
{"lvl":"DBG","ts":"2022-11-26 19:26:36.899+00:00","msg":"Received REST response body from remote server","remote":"builder-relay-goerli.flashbots.net:443","request":"/eth/v1/builder/validators","contentType":"text/html","size":192,"connection":"5"}

Builder API specs don't specify required allowed payload size, and there's a tradeoff between DoS-protection-trigger-risk and too-large-request-header risk, so try 1000 until more solid information comes in.

@tersec tersec enabled auto-merge (squash) November 26, 2022 21:11
@tersec tersec disabled auto-merge November 26, 2022 23:11
@tersec tersec merged commit 3829886 into unstable Nov 26, 2022
@tersec tersec deleted the DS7 branch November 26, 2022 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant