Don't use the wrong SECONDS_PER_ETH1_BLOCK constant #4709
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etan-status
reviewed
Mar 9, 2023
Comment on lines
-396
to
+397
| (blk.timestamp + cfg.SECONDS_PER_ETH1_BLOCK * cfg.ETH1_FOLLOW_DISTANCE <= period_start) and | ||
| (blk.timestamp + cfg.SECONDS_PER_ETH1_BLOCK * cfg.ETH1_FOLLOW_DISTANCE * 2 >= period_start) | ||
| (blk.timestamp + SECONDS_PER_SLOT * cfg.ETH1_FOLLOW_DISTANCE <= period_start) and | ||
| (blk.timestamp + SECONDS_PER_SLOT * cfg.ETH1_FOLLOW_DISTANCE * 2 >= period_start) |
There was a problem hiding this comment.
There was a problem hiding this comment.
The point is that the spec accidentally got wrong as a result of an oversight. The change here preserves the spirit of the original spec. Arguably, since this is the "honest validator" spec, some deviations are reasonable. It's unlikely that the proposed fix will cause any issues in practice because it effectively increases the size of the candidate set which should only prevent potential situations where Nimbus decides to disagree with the establishing majority in the Eth1Data voting.
|
Since, we've merged some alternative mitigations, I think we can wait for https://eips.ethereum.org/EIPS/eip-6110 as the eventual resolution for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.