Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't check legacy tables for pruning #5116

Merged
merged 3 commits into from
Jun 24, 2023
Merged

don't check legacy tables for pruning #5116

merged 3 commits into from
Jun 24, 2023

Conversation

arnetheduck
Copy link
Member

These tables can't be deleted from (read-only) and would be too slow to delete from anyway due to the inefficient storage format in use.

These tables can't be deleted from (read-only) and would be too slow to
delete from anyway due to the inefficient storage format in use.
@github-actions
Copy link

github-actions bot commented Jun 23, 2023

Unit Test Results

         9 files  ±0    1 071 suites  ±0   37m 40s ⏱️ - 1m 57s
  3 699 tests ±0    3 420 ✔️ ±0  279 💤 ±0  0 ±0 
15 763 runs  ±0  15 458 ✔️ ±0  305 💤 ±0  0 ±0 

Results for commit e38cc4a. ± Comparison against base commit 1bc9f3a.

♻️ This comment has been updated with latest results.

it's also broken because it tries to delete v0 data which is read-only
@arnetheduck arnetheduck merged commit d9bff54 into unstable Jun 24, 2023
8 checks passed
@arnetheduck arnetheduck deleted the prune-it branch June 24, 2023 14:14
zah pushed a commit that referenced this pull request Jun 26, 2023
These tables can't be deleted from (read-only) and would be too slow to
delete from anyway due to the inefficient storage format in use.

* slow down startup clearing too
* remove unused del function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants