initial integration of attestation pool with fork choice infrastructure #53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Of all things, this doesn't actually aggregate. I don't see how that's supposed to happen upstream of
get_latest_attestation
, which is the only part this addresses.This does integrate changes with @zah's minimal attestation pool in
fork_choice
, unlike the previous branch. I'm not entirely convinced this is better, as an architectural design -- it intermixes fork choice and other attestation pool mechanics, unlike https://github.com/status-im/nim-beacon-chain/tree/WorkPoolUpdates for example, rather than layering them -- but, sure, I'll give this a try.attestation_participants
inAttestationCandidate
would be for use in aggregating, which, see above, I'm not 100% convinced can live in this layer anyway, consistently with spec definitions.