Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial integration of attestation pool with fork choice infrastructure #53

Closed
wants to merge 1 commit into from

Conversation

tersec
Copy link
Contributor

@tersec tersec commented Jan 4, 2019

Of all things, this doesn't actually aggregate. I don't see how that's supposed to happen upstream of get_latest_attestation, which is the only part this addresses.

This does integrate changes with @zah's minimal attestation pool in fork_choice, unlike the previous branch. I'm not entirely convinced this is better, as an architectural design -- it intermixes fork choice and other attestation pool mechanics, unlike https://github.com/status-im/nim-beacon-chain/tree/WorkPoolUpdates for example, rather than layering them -- but, sure, I'll give this a try.

attestation_participants in AttestationCandidate would be for use in aggregating, which, see above, I'm not 100% convinced can live in this layer anyway, consistently with spec definitions.

@zah
Copy link
Member

zah commented Jan 5, 2019

This should have been done on top of the network-sim branch (now, merged in master)

@tersec tersec closed this Jan 7, 2019
@tersec tersec deleted the IntegrateWorkPoolWithForkChoicePart1 branch January 22, 2019 17:34
etan-status pushed a commit that referenced this pull request May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants