VC: Fix VC must not crash if beacon node address could not be resolved. #5388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnetheduck
reviewed
Sep 6, 2023
| let status = checkName(node) | ||
| node.updateStatus(status, ApiNodeFailure()) | ||
| if status == RestBeaconNodeStatus.Noname: | ||
| warn "Cannot initialize beacon node", node = node, status = status |
There was a problem hiding this comment.
will this be printed every 2 seconds on a node without name?
There was a problem hiding this comment.
yup, but only in situation when there no any node with name available, if there will be at least one node with name available this string will not be printed. Its initial check before we obtaining genesis. So it will print this message every 2 seconds for every beacon node in list.
arnetheduck
reviewed
Sep 11, 2023
| @@ -282,7 +296,10 @@ proc asyncInit(vc: ValidatorClientRef): Future[ValidatorClientRef] {.async.} = | |||
| beacon_nodes_count = len(vc.beaconNodes) | |||
|
|
|||
| for node in vc.beaconNodes: | |||
| notice "Beacon node initialized", node = node | |||
| if node.status == RestBeaconNodeStatus.Offline: | |||
arnetheduck
approved these changes
Sep 11, 2023
cheatfate
force-pushed
the
http-address
branch
from
2e8d2d7
to
40f4ed0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.