REST server fixes and improvements. #5422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tersec
reviewed
Sep 15, 2023
arnetheduck
reviewed
Sep 23, 2023
arnetheduck
reviewed
Sep 23, 2023
| except CatchableError: | ||
| return err("Unexpected deserialization error") | ||
| return err(RestErrorMessage.init(Http400, UnableDecodeError, | ||
| [version, exc.formatMsg("<data>")])) |
There was a problem hiding this comment.
so in general, this is where we would include a short version of the data itself?
There was a problem hiding this comment.
yes we can, but it will not be very helpful, we put escaped JSON into JSON, and so exc.formatMsg() will not provide proper offsets in the escaped JSON.
There was a problem hiding this comment.
it doesn't really matter - the point is more that the raw text usually contains an error message that the server has generated and therefore can be searched for when resolving problems .. it is a lot more useful than the json parsing error in general.
arnetheduck
approved these changes
Sep 23, 2023
Introduce more comprehensive error reporting for block calls. Deprecate decodeEthConsensusVersion() function.
cheatfate
force-pushed
the
rest-finalized
branch
from
2e12d7f
to
55f996f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finalizedflag to REST API calls/eth/v1/beacon/states/{state_id}/root/eth/v1/beacon/states/{state_id}/fork/eth/v1/beacon/states/{state_id}/finality_checkpoints/eth/v1/beacon/states/{state_id}/validator/eth/v1/beacon/states/{state_id}/validators/{validator_id}/eth/v1/beacon/states/{state_id}/validator_balances/eth/v1/beacon/states/{state_id}/committees/eth/v1/beacon/states/{state_id}/sync_committees/eth/v1/beacon/states/{state_id}/randao/eth/v1/beacon/headers/eth/v1/beacon/headers/{block_id}/eth/v2/beacon/blocks/{block_id}/eth/v1/beacon/blocks/{block_id}/root/eth/v1/beacon/blocks/{block_id}/attestations/eth/v1/beacon/states/{state_id}/validators- HTTP 414/eth/v1/beacon/blinded_blocks- HTTP 415, HTTP 400 (FOO)/eth/v1/beacon/blocks- HTTP 415/eth/v2/beacon/blocks- HTTP 415