Fix direct peers #5427
Merged
Fix direct peers #5427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I imagine making one of the peers in the local testnet script become a direct peer and disable all of the other ways it has of getting peers is the easiest thing to do - this "should" cause the local testnet to fail if the connection is not maintained. |
|
Done, though was a bit bloody as we need to know the ENRs of two nodes before-hand. |
arnetheduck
reviewed
Sep 15, 2023
docs/the_nimbus_book/src/options.md
Outdated
| connection to. This requires a not random netkey-file. In the multiaddress | ||
| format like: /ip4/<address>/tcp/<port>/p2p/<peerId-public-key>, or enr format | ||
| (enr:-xx). Peering agreements are established out of band and must be | ||
| reciprocal.. |
There was a problem hiding this comment.
Suggested change
| reciprocal.. | |
| reciprocal. |
There was a problem hiding this comment.
Oh, confutils is adding a dot, funny
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #5278
The libp2p sides fixes are here: vacp2p/nim-libp2p#949
I would like to add a test to the CI to makes sure it actually works, but not sure what's the best way to do so