stop calling engine_exchangeTransitionConfigurationV1 with Dencun-ready ELs #5585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zah
reviewed
Nov 9, 2023
| @@ -1400,6 +1400,11 @@ proc exchangeConfigWithSingleEL(m: ELManager, connection: ELConnection) {.async. | |||
|
|
|||
| connection.etcStatus = EtcStatus.match | |||
|
|
|||
| # https://github.com/ethereum/execution-apis/blob/c4089414bbbe975bbc4bf1ccf0a3d31f76feb3e1/src/engine/cancun.md#deprecate-engine_exchangetransitionconfigurationv1 | |||
| # Consensus layer clients MUST NOT call this method. | |||
| if m.eth1Chain.cfg.DENEB_FORK_EPOCH != FAR_FUTURE_EPOCH: | |||
There was a problem hiding this comment.
Isn't the spec saying that the ELs should stop reporting an error message about this once the Cancun fork epoch is reached? The check here is doing something different.
There was a problem hiding this comment.
I asked about this recently in an Eth R&D Discord thread in the #json-rpc-api channel:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ethereum/execution-apis#420
Once Dencun has become the baseline enough that a sufficient portion of the network is running a Dencun-capable EL, all
engine_exchangeTransitionConfigurationV1-related infrastructure can be removed (e.g.,TransitionConfigurationV1, etc), but this keeps it in place until then.It won't be necessary to wait until the very last holdout, because it's mainly to avoid the ELs creating warnings -- and at that point, the fix can be, update your EL client.