Batch slashing protection registration #5604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR brings down the time to send 100 attestations from ~1s to ~100ms, making it feasible to run 10k validators on a single node (which regularly send 300 attestations / slot). This is done by batching the slashing protection database write in a single transaction thus avoiding a slow fsync for every signature - effects will be more pronounced on slow drives. The benefit applies both to beacon and client validators.
arnetheduck
force-pushed
the
slashing-batch
branch
from
2d3be75
to
870c932
Compare
tersec
reviewed
Nov 17, 2023
| source, target, attestation_signing_root) | ||
|
|
||
| template withContext*(db: SlashingProtectionDB, body: untyped): untyped = |
There was a problem hiding this comment.
Doesn't the v1 slashing protection not ever write anymore? My understanding had been that it was there for read-only migration purposes only.
There was a problem hiding this comment.
this is not v1 - it's a leftover of the v1/v2 abstraction scheme (that technically could be cleaned up)
tersec
approved these changes
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings down the time to send 100 attestations from ~1s to ~100ms, making it feasible to run 10k validators on a single node (which regularly send 300 attestations / slot).
This is done by batching the slashing protection database write in a single transaction thus avoiding a slow fsync for every signature - effects will be more pronounced on slow drives.
The benefit applies both to beacon and client validators.