Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use debug- prefix for Yamux experimental support #6010

Merged
merged 1 commit into from
Mar 7, 2024
Merged

use debug- prefix for Yamux experimental support #6010

merged 1 commit into from
Mar 7, 2024

Conversation

tersec
Copy link
Contributor

@tersec tersec commented Mar 1, 2024

Discussed in #5080 (comment)

per https://nimbus.guide/options.html#available-options

Any debug-prefixed flags are considered ephemeral and subject to removal without notice.

It's already not documented because it's hidden; this just makes the existing policy explicit.

Copy link

github-actions bot commented Mar 1, 2024

Unit Test Results

         9 files  ±0    1 107 suites  ±0   23m 6s ⏱️ - 1m 52s
  4 233 tests ±0    3 886 ✔️ ±0  347 💤 ±0  0 ±0 
16 894 runs  ±0  16 496 ✔️ ±0  398 💤 ±0  0 ±0 

Results for commit 2779d2c. ± Comparison against base commit 0d48535.

@zah
Copy link
Member

zah commented Mar 1, 2024

Looks like the old name is in use here:
https://github.com/status-im/infra-nimbus/blob/aaa3c437a9bc23e5be854940990ce10d91f2bef9/ansible/group_vars/nimbus.mainnet.yml#L171

@jakubgs, would you coordinate this change?

@jakubgs
Copy link
Member

jakubgs commented Mar 7, 2024

Should I make the change before this is merged?

@tersec
Copy link
Contributor Author

tersec commented Mar 7, 2024

Should I make the change before this is merged?

If it's only the libp2p nodes without any validators (because mainnet test fleet) anyway, yeah. Make the change there, I'll merge, and within 24 hours, things will be synced again.

@jakubgs jakubgs merged commit 11d522d into unstable Mar 7, 2024
13 checks passed
@jakubgs jakubgs deleted the u3r branch March 7, 2024 18:52
jakubgs added a commit to status-im/infra-nimbus that referenced this pull request Mar 7, 2024
status-im/nimbus-eth2#6010

Signed-off-by: Jakub Sokołowski <jakub@status.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants