Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Electra SSZ object test fixture #6225

Merged
merged 1 commit into from
Apr 22, 2024
Merged

add Electra SSZ object test fixture #6225

merged 1 commit into from
Apr 22, 2024

Conversation

tersec
Copy link
Contributor

@tersec tersec commented Apr 22, 2024

  • AggregateAndProof/SignedAggregateAndProof are not actually there, just stubbed out; probably another one of the base-to-phase0-then-explicitly-specify-module maneuvers coming;
  • CommitteeValidatorsBits | ElectraCommitteeValidatorsBits could be combined into a single typeclass, probably, though Nim does have bugs here. They've not lately been breaking-at-runtime, i.e. if it compiles, this at least works across modules;
  • various internal data structures will need to be rethought to the extent they'll need queues of both phase0 and electra versions of Attestations/AttesterSlashings, but at least no pre-Electra regressions this way, by pinning them to the phase0 versions;
  • ElectraAttesterSlashing and similar will become electra.Foo rather than ElectraFoo

Copy link

Unit Test Results

         9 files  ±    0    1 121 suites  +6   34m 7s ⏱️ + 3m 1s
  4 252 tests +    7    3 905 ✔️ +    7  347 💤 ±0  0 ±0 
17 259 runs  +330  16 861 ✔️ +330  398 💤 ±0  0 ±0 

Results for commit b169ebd. ± Comparison against base commit d139c92.

@tersec tersec merged commit 8745237 into unstable Apr 22, 2024
13 checks passed
@tersec tersec deleted the 5XY branch April 22, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant