Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trancscript10 #18

Merged
merged 4 commits into from Feb 25, 2019
Merged

Trancscript10 #18

merged 4 commits into from Feb 25, 2019

Conversation

deeayeen
Copy link
Contributor

Agenda headers included in transcript. Happy to do future transcripts for a slightly higher bounty 馃憤

@oskarth
Copy link
Contributor

oskarth commented Feb 22, 2019

Thanks @deeayeen! I'll have a look at this on Monday, hope that's OK.

@pombeirp @hesterbruikman would you mind having a look too? Couldn't request you to review for some reason.

Copy link
Contributor

@hesterbruikman hesterbruikman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Below a few minor changes, sorry I couldn't directly edit them in. Mostly name corrections:

11:00-12:00 Andrey Andrea
18:00-19:00 Cory Corey
19:00-20:00 (last paragraph above) annabel... Jarrad or Nabil
19:00-20:00 Status Nabil
22:00-23:00 digital tracker pivotaltracker
35:00-36:00 Andrey Andrei , context contact
36:00-37:00 Andrey Andrei
38:00-39:00 Frog ProgPOW

@deeayeen
Copy link
Contributor Author

@hesterbruikman @oskarth
Thanks, fixed

Copy link
Contributor

@oskarth oskarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, some minor comments. Thanks!

Out of curiosity, how long did this PR take you in total?

notes/transcript10.md Outdated Show resolved Hide resolved
notes/transcript10.md Outdated Show resolved Hide resolved
notes/transcript10.md Outdated Show resolved Hide resolved
@oskarth
Copy link
Contributor

oskarth commented Feb 25, 2019

Oh, would you mind adding this as a link 'transcript' from README as well? Under the 10th issue in the table

@deeayeen
Copy link
Contributor Author

Oh, would you mind adding this as a link 'transcript' from README as well? Under the 10th issue in the table

@oskarth

Of course! PR'ed all the fixes and added to readme.

All in all it took me about two and a half hours. I also learned the concepts along the way, so future transcriptions will be more accurate.

@oskarth
Copy link
Contributor

oskarth commented Feb 25, 2019

Great, cheers @deeayeen! Feel free to join us in #status-core-devs if you want as well :)

That was slightly more than expected, so I added two more issues with "size-s" (previous was size-xs), pending funding. cc @StatusSceptre

@oskarth oskarth merged commit d4ea26c into status-im:master Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants