Skip to content

Commit

Permalink
ci: remove caching of dependencies
Browse files Browse the repository at this point in the history
Upgrade of Jenkins to `2.343` has introduced a security fix that breaks
caching plugin when it's configured to store cache on Master host:
https://issues.jenkins.io/browse/JENKINS-67173

Sine the [Caching plugin](https://plugins.jenkins.io/jobcacher/) hasn't
been upgraded in 5 years the only good temporary workaround is just drop
caching of dependencies like Nim compiler entirely.

In the future we can try some other caching methods.

Related: status-im/nimbus-eth2#3594

Signed-off-by: Jakub Sokołowski <jakub@status.im>
  • Loading branch information
jakubgs committed Apr 15, 2022
1 parent d94abcb commit b8a00f1
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 31 deletions.
10 changes: 2 additions & 8 deletions ci/Jenkinsfile.linux
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,8 @@ pipeline {
steps {
/* trigger fetching of git submodules */
sh 'make check-pkg-target-linux'
/* avoid re-compiling Nim by using cache */
cache(maxCacheSize: 250, caches: [[
$class: 'ArbitraryFileCache',
includes: '**/*',
path: 'vendor/nimbus-build-system/vendor/Nim/bin'
]]) {
sh 'make deps'
}
/* TODO: Re-add caching of Nim compiler. */
sh 'make deps'
}
}

Expand Down
24 changes: 9 additions & 15 deletions ci/Jenkinsfile.macos
Original file line number Diff line number Diff line change
Expand Up @@ -50,21 +50,15 @@ pipeline {
steps {
/* trigger fetching of git submodules */
sh 'make check-pkg-target-macos'
/* avoid re-compiling Nim by using cache */
cache(maxCacheSize: 250, caches: [[
$class: 'ArbitraryFileCache',
includes: '**/*',
path: 'vendor/nimbus-build-system/vendor/Nim/bin'
]]) {
withCredentials([
usernamePassword( /* For fetching HomeBrew bottles. */
credentialsId: "status-im-auto-pkgs",
usernameVariable: 'GITHUB_USER',
passwordVariable: 'GITHUB_TOKEN'
)
]) {
sh 'make deps'
}
/* TODO: Re-add caching of Nim compiler. */
withCredentials([
usernamePassword( /* For fetching HomeBrew bottles. */
credentialsId: "status-im-auto-pkgs",
usernameVariable: 'GITHUB_USER',
passwordVariable: 'GITHUB_TOKEN'
)
]) {
sh 'make deps'
}
}
}
Expand Down
10 changes: 2 additions & 8 deletions ci/Jenkinsfile.windows
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,8 @@ pipeline {
steps {
/* trigger fetching of git submodules */
sh 'make check-pkg-target-windows'
/* avoid re-compiling Nim by using cache */
cache(maxCacheSize: 250, caches: [[
$class: 'ArbitraryFileCache',
includes: '**/*',
path: 'vendor/nimbus-build-system/vendor/Nim/bin'
]]) {
sh 'make deps'
}
/* TODO: Re-add caching of Nim compiler. */
sh 'make deps'
}
}

Expand Down

0 comments on commit b8a00f1

Please sign in to comment.