remove Jenkins caching #3594
Merged
remove Jenkins caching #3594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnetheduck
approved these changes
Apr 14, 2022
jakubgs
added a commit
to status-im/status-desktop
that referenced
this pull request
Apr 15, 2022
Upgrade of Jenkins to `2.343` has introduced a security fix that breaks caching plugin when it's configured to store cache on Master host: https://issues.jenkins.io/browse/JENKINS-67173 Sine the [Caching plugin](https://plugins.jenkins.io/jobcacher/) hasn't been upgraded in 5 years the only good temporary workaround is just drop caching of dependencies like Nim compiler entirely. In the future we can try some other caching methods. Related: status-im/nimbus-eth2#3594 Signed-off-by: Jakub Sokołowski <jakub@status.im>
0x-r4bbit
pushed a commit
to status-im/status-desktop
that referenced
this pull request
Apr 15, 2022
Upgrade of Jenkins to `2.343` has introduced a security fix that breaks caching plugin when it's configured to store cache on Master host: https://issues.jenkins.io/browse/JENKINS-67173 Sine the [Caching plugin](https://plugins.jenkins.io/jobcacher/) hasn't been upgraded in 5 years the only good temporary workaround is just drop caching of dependencies like Nim compiler entirely. In the future we can try some other caching methods. Related: status-im/nimbus-eth2#3594 Signed-off-by: Jakub Sokołowski <jakub@status.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Jenkins was updated to incorporate https://issues.jenkins.io/browse/JENKINS-67173 in version 2.326, it's been showing
In general, Jenkins plugins need to have been updated to this. However, https://plugins.jenkins.io/jobcacher/ hasn't been updated in 5 years, and certainly not for a security fix from a few months ago. This incompatibility between the post-security-fix Jenkins and the non-updated Job Cacher plugin means that the workaround that https://www.jenkins.io/redirect/security-144 suggests doesn't exist anymore.
There might be an alternative caching plugin, or approach, but in the meantime, disable Jenkins caching for the Nim compiler.