Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contacts: No toast is displayed after removing a contact #10497

Closed
glitchminer opened this issue May 1, 2023 · 1 comment · Fixed by #12319
Closed

Contacts: No toast is displayed after removing a contact #10497

glitchminer opened this issue May 1, 2023 · 1 comment · Fixed by #12319
Assignees
@shinnok
Labels
backend-team bug Something isn't working E:Desktop Contact Requests Anything related to mutual contacts and sending/receiving contact requests
Milestone
0.15

Comments

@glitchminer
Copy link
Contributor

Bug Report

Description

Split from and dependant on #10336

After removing a contact, an in app toast notification is expected but not currently displayed

Steps to reproduce

Remove a contact via the contact's profile
Observe that no toast is displayed

Additional Information
@glitchminer glitchminer added bug Something isn't working Chat backend-team labels May 1, 2023
@iurimatias iurimatias added this to the 0.13 milestone May 3, 2023
@John-44
Copy link

John-44 commented May 8, 2023

@benjthayer see my comment on issue #10498

Same question as that other issue really, and would like to get your thoughts on this question.

@iurimatias iurimatias modified the milestones: 0.13, 0.14 May 10, 2023
@iurimatias iurimatias modified the milestones: 0.14, 0.15 Jun 13, 2023
@iurimatias iurimatias added the C1 label Jun 19, 2023
@jrainville jrainville modified the milestones: 0.14, 0.15 Jun 22, 2023
@jrainville jrainville removed the C1 label Jun 22, 2023
@jrainville jrainville assigned mprakhov and shinnok and unassigned mprakhov Aug 31, 2023
@jrainville jrainville added the E:Desktop Contact Requests Anything related to mutual contacts and sending/receiving contact requests label Sep 18, 2023
shinnok added a commit that referenced this issue Oct 2, 2023
@shinnok
Add toast notification when removing a contact
e5d29a4 
Fixes #10497
@shinnok shinnok mentioned this issue Oct 2, 2023
Merged
shinnok added a commit that referenced this issue Oct 3, 2023
@shinnok
fix(messenger_contacts): Add toast notification when removing a contact
d9e6fbe 
Fixes #10497
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shinnok shinnok

Labels
backend-team bug Something isn't working E:Desktop Contact Requests Anything related to mutual contacts and sending/receiving contact requests
Projects
Status Desktop/Mobile Board
Archived in project
Milestone
0.15
Development

Successfully merging a pull request may close this issue.

fix(messenger_contacts): Add toast notification when removing a contact status-im/status-desktop
6 participants
@iurimatias @shinnok @jrainville @John-44 @glitchminer @mprakhov