Able to send reaction in token gated communities

[alaibe]

Members not yet approved in the communities are able to send reaction to message

Expected: they should not be able to react

[shinnok]

Hi,

I cannot reproduce this on latest dev, on a test Community, with existing or new messages, neither with mouse hover nor right click.

temporary-krantzite-hepialus.mov

[jrainville]

I tried also and I can't reproduce. I wonder what made it possible before.

Maybe one other thing you could try @shinnok is remove the UI blockers and try to send a message or emoji reaction when not part of a community.

The messages should not appear for other users, ie status-go should not accept those (backend validation). Can you confirm that please?

[shinnok]

@jrainville I re-enabled the chat input by commenting out the piece below and I was able to send messages to a community without having joined yet:

status-desktop/ui/app/AppLayouts/Chat/views/ChatColumnView.qml

Lines 260 to 267 in 29629a3

	Binding on enabled {
	delayed: true
	value: !!d.activeChatContentModule
	&& !d.activeChatContentModule.chatDetails.blocked
	&& root.rootStore.sectionDetails.joined
	&& !root.rootStore.sectionDetails.amIBanned
	&& root.rootStore.isUserAllowedToSendMessage
	}

As for the best place to block this in the back-end, I'm currently investigating in status-go PR status-im/status-go#4064.

[jrainville]

Nice find @shinnok .

So we should block that both on sending side, but most importantly on receiver side, so that if someone clones the repo and "hacks" the sending code, we still don't accept messages from non-members.

I recommend using the Go tests available in status-go. They are very powerful (you can debug) and way faster than running the app.

Let me know if you need some coaching on them. All members of the messenger team know how they work, so you can reach out to any of them.

[igor-sirotin]

related: status-im/status-go#3869