Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replies lose the color on delete and are missing the user info on reload #12785

Closed
jrainville opened this issue Nov 17, 2023 · 0 comments · Fixed by #12820
Closed

Replies lose the color on delete and are missing the user info on reload #12785

jrainville opened this issue Nov 17, 2023 · 0 comments · Fixed by #12820
Assignees
@jrainville
Labels
bug Something isn't working
Milestone
2.27.0 Alpha

Comments

@jrainville
Copy link
Member

Bug Report

Description

If you delete the quoted message of a reply, at first, it keeps the user info, but still loses the color, which is not right.

Afterwards, if you reload, it then loses all user info.

image

In the image above, you can see both. The reloaded state is the message above. The "just deleted" state is the second one.
Ignore the Resend message.

Steps to reproduce

  1. Send a message in a chat
  2. Reply to that message
  3. See that the user color changed
  4. Reload the app
  5. See that the quoted user info disapeared

Expected behavior

The user info that was previously availbe in a quoted message should still be available after the original message was deleted.

Actual behavior

Missing user color, then missing info completely

Additional Information

  • Status desktop version: master 03d4fbcc48f1db4c49fc2c9a99ff6de242d620eb
  • Operating System: Ubuntu 20
@jrainville jrainville added bug Something isn't working messenger-team labels Nov 17, 2023
@jrainville jrainville self-assigned this Nov 21, 2023
jrainville added a commit to status-im/status-go that referenced this issue Nov 21, 2023
@jrainville
fix(message_persistence): set from in quoted message even when deleted
2f0d452 
Needed for status-im/status-desktop#12785
@jrainville jrainville mentioned this issue Nov 21, 2023
Merged
jrainville added a commit that referenced this issue Nov 21, 2023
@jrainville
fix(message): fix deleting a quoted message loses the user info
4560a0a 
Fixes #12785
@jrainville jrainville mentioned this issue Nov 21, 2023
Merged
jrainville added a commit to status-im/status-go that referenced this issue Nov 23, 2023
@jrainville
fix(message_persistence): set from in quoted message even when deleted
43f1175 
Needed for status-im/status-desktop#12785
jrainville added a commit to status-im/status-go that referenced this issue Nov 23, 2023
@jrainville
fix(message_persistence): set from in quoted message even when deleted (
b7acde0 
#4354)

Needed for status-im/status-desktop#12785
jrainville added a commit that referenced this issue Nov 23, 2023
@jrainville
fix(message): fix deleting a quoted message loses the user info
f4eef9b 
Fixes #12785
jrainville added a commit that referenced this issue Nov 23, 2023
@jrainville
fix(message): fix deleting a quoted message loses the user info
d719f9b 
Fixes #12785
jrainville added a commit that referenced this issue Nov 24, 2023
@jrainville
fix(message): fix deleting a quoted message loses the user info
cc5e32c 
Fixes #12785
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrainville jrainville

Labels
bug Something isn't working
Projects
Status Desktop/Mobile Board
Archived in project
Milestone
2.27.0 Alpha
Development

Successfully merging a pull request may close this issue.

fix(message): fix deleting a quoted message loses the user info status-im/status-desktop
2 participants
@iurimatias @jrainville