Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering TXs history issue #13663

Closed
saledjenic opened this issue Feb 21, 2024 · 6 comments · Fixed by #14069
Closed

Filtering TXs history issue #13663

saledjenic opened this issue Feb 21, 2024 · 6 comments · Fixed by #14069
Assignees
Labels
bug Something isn't working
Milestone

Comments

@saledjenic
Copy link
Contributor

When the user is filtering TXs by an address won't see any results in some scenarios even TXs with such an address appear in the list when there is no filtering.

What else can be seen in this video:

  • the address the user added to saved addresses is not displayed in the "Recent" tab of "Counterparty" of the filter popup menu
  • after the user added the address to saved addresses, it appeared in the"Saved" tab of "Counterparty", but still there is no address in the "Recent" tab
  • another issue is, that when the user filters by some address selected from the "Recent" tab of "Counterparty", it will appear in the filtering line as an address, that's ok, but then if the user goes to details and saves that address to saved addresses, it remains in the filtering line as an address, not changed to saved address' name.
SearchByAddressForFrom.mov
@saledjenic saledjenic added bug Something isn't working wallet-team labels Feb 21, 2024
@alaibe alaibe added this to the 2.29.0 Beta milestone Feb 21, 2024
@stefandunca
Copy link
Contributor

stefandunca commented Mar 20, 2024

@saledjenic the counterparty is interpreted as recipient. In the first screen I can't see transactions where the save address is the recipient (except for bridge), so it might be expected if you think you didn't have one.

Now I'm wondering if this interpretation of counterparty is correct, I will look again into designs.

Regarding bridge transaction, I'm looking into why is not shown.

@stefandunca stefandunca self-assigned this Mar 20, 2024
@stefandunca
Copy link
Contributor

stefandunca commented Mar 20, 2024

Looking further into it it seems one of the problem is that menu for saving from address should not be available. I'm looking into fixing this first.

Found another instance where the menu is present.

@stefandunca
Copy link
Contributor

Now looking into why menu is not shown. It seems that TransactionAddress is instantiated in TransactionAddressTile, however root.addresses are null

stefandunca added a commit that referenced this issue Mar 20, 2024
I was debugging a crash at login and found out that
TransactionDetailView was being loaded even when it was not being used;
my debugging code in `onComplete` was trying to access transaction data
from nim which was not set.

Updates #13663
@stefandunca
Copy link
Contributor

For save address lookup for newly created saved addresses it seems the model is not mapped directly to the lookup and the lookup is done manually. I will continue searching for a simple fix to force refresh the query.

In the meantime I found and fixed other small issues in this draft #14069

@stefandunca
Copy link
Contributor

When the user is filtering TXs by an address won't see any results in some scenarios even TXs with such an address appear in the list when there is no filtering.

I can't reproduce the issue therefore I assume for now that there were not transaction to the selected address in the list.

@anastasiyaig anastasiyaig modified the milestones: 2.29.0 Beta, 2.28.0 Beta RC Mar 21, 2024
@anastasiyaig
Copy link
Contributor

i changed milestone for this to be included into 2.28 release. It contains the fixes for the empty transaction details that is also a regression from 2.27

stefandunca added a commit that referenced this issue Mar 25, 2024
I was debugging a crash at login and found out that
TransactionDetailView was being loaded even when it was not being used;
my debugging code in `onComplete` was trying to access transaction data
from nim which was not set.

Updates #13663
@iurimatias iurimatias modified the milestones: 2.28.0 Beta RC, 2.28.0 Beta Mar 25, 2024
kounkou pushed a commit that referenced this issue Apr 4, 2024
I was debugging a crash at login and found out that
TransactionDetailView was being loaded even when it was not being used;
my debugging code in `onComplete` was trying to access transaction data
from nim which was not set.

Updates #13663
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.

5 participants